Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom properties to uui-tag #791

Merged
merged 2 commits into from
May 23, 2024

Conversation

TheRealArtonn
Copy link
Contributor

@TheRealArtonn TheRealArtonn commented Apr 30, 2024

Extending uui-tag with custom properties in order to style it for the new modern umbraco cloud portal design.

Description

I've added three properties to modify the padding, border-radius and border color of the uui.tag

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

We want the ability to adapt the uui-tag better to our own needs and styling.

How to test?

Change properties

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Extending uui-tag with custom properties in order to style it for the new modern umbraco cloud portal design.
@iOvergaard iOvergaard merged commit 46fde86 into v1/contrib May 23, 2024
8 of 11 checks passed
@iOvergaard iOvergaard deleted the feat/add-custom-properties-to-uui-tag branch May 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants