Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uui-button): 🚑 add back missing animation #782

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(uui-button): 🚑 add back missing animation #782

merged 1 commit into from
Apr 15, 2024

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Apr 12, 2024

Description

This Pr fixes what I broke before by adding keyframes back in 😅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-782.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Apr 15, 2024
iOvergaard
iOvergaard approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thanks!

@iOvergaard iOvergaard merged commit 5a1fea7 into v1/contrib Apr 15, 2024
11 of 12 checks passed
@iOvergaard iOvergaard deleted the fix/add-missing-keyframes-back branch April 15, 2024 07:23
@iOvergaard iOvergaard changed the title fix: 🚑 add back missing animation fix(uui-button): 🚑 add back missing animation Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julczka @iOvergaard