Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update uui-box.element.ts to support border color changeability #780

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

TheRealArtonn
Copy link
Contributor

Description

In the cloud portal we would like the ability to change the border color of uui-box to fit our theme better. Here in this PR we simply added a custom property to support that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Currently the uui-box border color is static, we would like to be able to adapt the color to our needs. This introduces the possibility of making that possible.

How to test?

overwrite the --uui-box-border-color, and see it take effect.

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard added the bug Something isn't working label Apr 11, 2024
@iOvergaard iOvergaard enabled auto-merge (rebase) April 11, 2024 07:26
@iOvergaard iOvergaard disabled auto-merge April 11, 2024 07:27
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-780.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit 455c1ca into v1/contrib Apr 11, 2024
11 of 12 checks passed
@iOvergaard iOvergaard deleted the add-color-property-for-border-color branch April 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants