Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix interface types with UUI #716

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Prefix interface types with UUI #716

merged 6 commits into from
Jan 23, 2024

Conversation

JesmoDev
Copy link
Contributor

Prefixes interface types with UUI to align with our other UUI types

  • UUIInterfaceLook
  • UUIInterfaceLookValues
  • UUIInterfaceColor
  • UUIInterfaceColorValues
  • UUIInterfaceHeading
  • UUIInterfaceHeadingValues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev added the breaking Breaks existing functionality label Jan 22, 2024
nielslyngsoe
nielslyngsoe approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-716.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the enhancement New feature or request label Jan 23, 2024
iOvergaard
iOvergaard requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed because of this, I think:

packages/uui-badge/lib/uui-badge.element.ts Outdated Show resolved Hide resolved
@iOvergaard iOvergaard enabled auto-merge (squash) January 23, 2024 14:44
@nielslyngsoe
update missing UUIInterfaceLook
2970202
@nielslyngsoe
Merge branch 'chore/interface-types-UUI-prefix' of https://github.com…
0a4bf0b 
…/umbraco/Umbraco.UI into chore/interface-types-UUI-prefix

# Conflicts:
#	packages/uui-badge/lib/uui-badge.element.ts
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-716.westeurope.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-716.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-716.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit 7cd20db into v1/contrib Jan 23, 2024
9 of 10 checks passed
@iOvergaard iOvergaard deleted the chore/interface-types-UUI-prefix branch January 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
breaking Breaks existing functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesmoDev @iOvergaard @nielslyngsoe