Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: direct imports are not allowed #703

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

iOvergaard
Copy link
Contributor

Description

Elements should not import other elements directly but instead utilize the demandCustomElement function. This fixes a few components that were doing this as well as organizing the imports.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@iOvergaard iOvergaard added the bug Something isn't working label Jan 10, 2024
@iOvergaard iOvergaard requested a review from julczka January 10, 2024 11:01
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-703.westeurope.azurestaticapps.net

@julczka julczka merged commit 81fade3 into v1/contrib Jan 11, 2024
11 checks passed
@julczka julczka deleted the v1/bugfix/no-direct-imports branch January 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants