Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uui-textarea: autoheight not working correctly #636

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Oct 30, 2023

Description

Fixes the issue where the height of textarea would render incorrectly on initial load, if textarea is set to "auto-height" and the initial value is multiple lines long.

The bug was caused by something related to the font family inherited. Fixed the issue by setting an initial line height of textarea.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-636.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-636.westeurope.azurestaticapps.net

@loivsen loivsen requested a review from nielslyngsoe October 30, 2023 11:27
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-D

@nielslyngsoe nielslyngsoe merged commit 2857008 into v1/contrib Nov 7, 2023
8 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/auto-height-textarea branch November 7, 2023 09:05
@iOvergaard iOvergaard added the bug Something isn't working label Nov 7, 2023
@iOvergaard iOvergaard changed the title text area autoheight fix uui-text-area: fix for autoheight Nov 7, 2023
@iOvergaard iOvergaard changed the title uui-text-area: fix for autoheight uui-text-area: autoheight not working correctly Nov 7, 2023
@iOvergaard iOvergaard changed the title uui-text-area: autoheight not working correctly uui-textarea: autoheight not working correctly Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants