Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update essential icons to use lucide #629

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Oct 27, 2023

Potentially breaking. This PR changes icon component, that before set color via SVG fill to use color instead. This matches with the approach of Lucide. This means that SVGs have to use the currentColor property on the elements/props that they like to be affected — enabling both fill and stroke based SVGs to work. But potentially break existing icons (This is handled in v.14)

image

This also removes the book alt icon, it does not belong as part of the UI Library.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-629.westeurope.azurestaticapps.net

@bjarnef
Copy link
Contributor

bjarnef commented Oct 27, 2023

@nielslyngsoe looks more modern that the current 10 years old icon set 😁

It would be great if we can consider icon categories in the new backoffice although not specific related to UI library.
https://lucide.dev/icons/categories

I also like the search on e.g. "home" find icons based on categories/keywords/tags and not only icon name for example lamp icon.
https://lucide.dev/icons/lamp

An older discussion as reference:
umbraco/Umbraco-CMS#9122

@bjarnef
Copy link
Contributor

bjarnef commented Oct 31, 2023

It seems lucide icons includes some schema file including tags and categories:
https://github.com/lucide-icons/lucide/blob/main/icons/accessibility.json

Feather icons does something similar:
https://github.com/feathericons/feather/blob/main/src/tags.json

Not sure if the existing schema files from lucide icons can be used or maybe we want to create our own schema file for icons? E.g. considering custom icons can be registered or another icon packs. @nielslyngsoe @iOvergaard

Out of scope for this PR, but worth considering :)

@nielslyngsoe
Copy link
Member Author

@bjarnef Yes, this was on my awareness.

So it's should not be part of UI Library. But here is a PR on the same topic for New Backoffice.
umbraco/Umbraco.CMS.Backoffice#963

Not sure if I have time to append this now, but It's on my radar, and I also got verbal approval from Joe Gombek on migrating the thesaurus package, https://github.com/glombek/umbicosaurus so we should find ways to get both data sets together.

@bjarnef
Copy link
Contributor

bjarnef commented Nov 6, 2023

Great! yeah, I have seen the Umbicosaurus package before by @glombek .. I haven't tried it out, but I see what it does 🐱‍🐉
https://github.com/glombek/umbicosaurus/blob/main/thesaurus.json

The thesaurus property could be tags and group could be categories or group. We could probably have a dropdown to easily filter icons on group/category.

@iOvergaard iOvergaard merged commit bb51e80 into v1/contrib Nov 7, 2023
8 checks passed
@iOvergaard iOvergaard deleted the v1/feature/new-icons branch November 7, 2023 10:05
@iOvergaard iOvergaard added the enhancement New feature or request label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants