-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update essential icons to use lucide #629
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-629.westeurope.azurestaticapps.net |
@nielslyngsoe looks more modern that the current 10 years old icon set 😁 It would be great if we can consider icon categories in the new backoffice although not specific related to UI library. I also like the search on e.g. "home" find icons based on categories/keywords/tags and not only icon name for example lamp icon. An older discussion as reference: |
It seems lucide icons includes some schema file including tags and categories: Feather icons does something similar: Not sure if the existing schema files from lucide icons can be used or maybe we want to create our own schema file for icons? E.g. considering custom icons can be registered or another icon packs. @nielslyngsoe @iOvergaard Out of scope for this PR, but worth considering :) |
@bjarnef Yes, this was on my awareness. So it's should not be part of UI Library. But here is a PR on the same topic for New Backoffice. Not sure if I have time to append this now, but It's on my radar, and I also got verbal approval from Joe Gombek on migrating the thesaurus package, https://github.com/glombek/umbicosaurus so we should find ways to get both data sets together. |
Great! yeah, I have seen the Umbicosaurus package before by @glombek .. I haven't tried it out, but I see what it does 🐱🐉 The |
Potentially breaking. This PR changes icon component, that before set color via SVG fill to use color instead. This matches with the approach of Lucide. This means that SVGs have to use the currentColor property on the elements/props that they like to be affected — enabling both fill and stroke based SVGs to work. But potentially break existing icons (This is handled in v.14)
This also removes the book alt icon, it does not belong as part of the UI Library.