Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the required Node and NPM versions in the "How to get started" section of CONTRIBUTING.md #611

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

OwainJ
Copy link
Contributor

@OwainJ OwainJ commented Oct 14, 2023

Description

Updated the required Node and NPM versions in the "How to get started" section of CONTRIBUTING.md.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

When cloning the repo I followed the "How to get started" in the contributing guide, as instructed, I installed Node v16, but it gave a warning when running npm install; so I thought I would just quickly update the instructions in the contributing guide to match the versions specified in the actual package.json.

How to test?

Screenshots (if appropriate)

image
The warning that appears when using Node v16

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Updated the required Node and NPM versions in the "How to get started" section
@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Hi there @OwainJ, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard iOvergaard added documentation Improvements or additions to documentation community/pr hacktoberfest/contrib-2023 labels Oct 17, 2023
@iOvergaard iOvergaard merged commit ba5760e into umbraco:v1/contrib Oct 17, 2023
5 of 8 checks passed
@iOvergaard
Copy link
Contributor

Nice update, thanks! #h5yr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr documentation Improvements or additions to documentation hacktoberfest/contrib-2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants