Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/modal missing close event #598

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Bugfix/modal missing close event #598

merged 3 commits into from
Oct 5, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Oct 5, 2023 •
edited
Loading

Description

Reinstates the close-end event, which is dispatched after close animations or delays right before the component is removed from the dom

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev marked this pull request as ready for review October 5, 2023 05:05
@JesmoDev JesmoDev requested a review from madsrasmussen October 5, 2023 05:05
@nielslyngsoe nielslyngsoe merged commit 825d722 into v1/contrib Oct 5, 2023
7 of 8 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/modal-missing-close-event branch October 5, 2023 10:33
@iOvergaard iOvergaard added the bug Something isn't working label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

@madsrasmussen madsrasmussen Awaiting requested review from madsrasmussen

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesmoDev @nielslyngsoe @iOvergaard