Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uui-textarea: font size and auto-height optimisations #597

Merged
merged 5 commits into from
Oct 10, 2023
Merged

uui-textarea: font size and auto-height optimisations #597

merged 5 commits into from
Oct 10, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Oct 4, 2023 •
edited
Loading

Description

Textarea changes

  • Enabled the option to change font-size of the uui-textarea by setting --uui-textarea-font-size.
  • Textarea font is now inherited.
  • Improved the auto-height for textarea to render the correct height.
  • Textarea auto-height now sets height on initial render.

Notes

  • Test the textarea with auto-height with a large initial value. The height will be slightly incorrect on initial render. This is due to the font-family inherited. Need a solution to render it correctly on first render without it being too hacky.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-597.westeurope.azurestaticapps.net

@loivsen loivsen marked this pull request as draft October 4, 2023 12:27
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-597.westeurope.azurestaticapps.net

@loivsen loivsen marked this pull request as ready for review October 5, 2023 07:15
@nielslyngsoe nielslyngsoe self-requested a review October 5, 2023 19:19
@loivsen loivsen changed the title textarea font size Textarea font size and auto-height changes Oct 9, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-597.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-597.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-597.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title Textarea font size and auto-height changes uui-textarea: font size and auto-height optimisations Oct 10, 2023
@iOvergaard iOvergaard added the enhancement New feature or request label Oct 10, 2023
@iOvergaard iOvergaard merged commit 3917c08 into v1/contrib Oct 10, 2023
8 checks passed
@iOvergaard iOvergaard deleted the feature/textarea-font-size branch October 10, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

@nielslyngsoe nielslyngsoe Awaiting requested review from nielslyngsoe

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loivsen @iOvergaard @nielslyngsoe