-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visually hidden component #593
Visually hidden component #593
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@iOvergaard
but the rest of the packages just includes:
|
@bjarnef that is technically a better way to export es modules. We probably need to change the whole library to use that style at some point. I don't know if it brings any value at this point, so feel free to change it back to the same style as the rest of the imports. I think you need to run prettier to make the tests pass, though, and could you perhaps add some more context in the README so people know why the component is useful? Shoelace has a wonderful description on their page for why it's important with such a component. |
@iOvergaard regarding description do you think it need to add additional description after "Umbraco style visually-hidden component." or just change/update this text? I have run prettier, but some of this format was actually formatted when running The build error doesn't seem to be related to this component though? |
Description
Often in the current Umbraco backoffice we had something like this to provide information to screen readers, but not visually hidden to users.
https://github.com/umbraco/Umbraco-CMS/blob/511ee96c9e0c54480b5350fa0bcabe693bdc1e0a/src/Umbraco.Web.UI.Client/src/views/components/umb-lightbox.html#L7-L9C12
Inspired by the https://shoelace.style/components/visually-hidden component, I think it would be useful to have a
<uui-visually-hidden>
component.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist