-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specific control types in storybook controls #537
Specific control types in storybook controls #537
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Looks good to me, @bjarnef! Would you run prettier on the files to make sure it passes the tests? Then I'll get it merged :) |
@iOvergaard I executed |
@iOvergaard any changes required for this or can it be merged? :) |
Updated this with support of HSV color format in #610 |
Description
This PR makes some enhancements reported in #535
From https://storybook.js.org/docs/7.0/react/essentials/controls#choosing-the-control-type
In color picker we have some properties with specific values, where we can use the enum based controls instead.
I have also changes control type of
value
property to "color" control, which seems to work with both hex and rgba.I updated the "With opacity" story with an initial value of
rgba(0, 0, 0, 0.5)
to demonstrate an initial value with opacity and the control type is set to this as well.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist