-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update saturation based on parsed color #536
Merged
iOvergaard
merged 23 commits into
umbraco:v1/contrib
from
bjarnef:bug/color-area-saturation
Feb 5, 2024
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8397ad4
Don't update saturation based on parsed color
bjarnef a716476
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 87f951a
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 9fe8a29
Workaround to update color area when hue slider change
bjarnef 35e7860
Fix typo
bjarnef dd34062
Don't change opacity of gradient in opacity-slider as value change an…
bjarnef 6468c60
Make handle opacity based on alpha
bjarnef ea6af27
Clear console
bjarnef 2570972
Clear console
bjarnef 5eec6bd
Clear console
bjarnef 77774cb
Add comment
bjarnef 75bfabf
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 6d26f02
Remove output of hue value
bjarnef a1dd812
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 03e3b72
Update saturation
bjarnef 3bdf47a
Don't update saturation
bjarnef 68b0de2
Merge branch 'v1/contrib' into bug/color-area-saturation
iOvergaard 06e324c
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef ade0a0f
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 7d803bb
Merge branch 'v1/contrib' into bug/color-area-saturation
bjarnef 429f299
Remove commented line
bjarnef 49e54c5
Remove unused parameter
bjarnef f9598d5
Run linter
bjarnef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the following here, but it seem it made the handle "jump" and bit anyway and the color spectrum seemed to be affected. When dragging the handle in the spectrum, I would expect the gradient shouldn't change.