Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input type #974

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Nov 8, 2023

Description

With the support of search input type in UI library we should use this for search and filter input fields to be more semantic correct and also provide a slightly different virtual keyboard on many devices.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard
Copy link
Collaborator

Looks good to me. Would you be able to fix the merge conflicts, then we can proceed to merge this PR, @bjarnef?

@bjarnef
Copy link
Contributor Author

bjarnef commented Nov 20, 2023

@iOvergaard yeah, I need to merge latest changes and probably easiest to ignore my changes and re-add these.
Apparently they are too complex to resolve 😜

image

@bjarnef
Copy link
Contributor Author

bjarnef commented Nov 26, 2023

@iOvergaard not sure what GitHub complained about here. I pulled latest changes from upstream main branched and pushed to this remote branch. There were no conflicts.

Anyway it should be ready to merge now :)

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks also good to me

@nielslyngsoe nielslyngsoe merged commit f607afd into umbraco:main Nov 27, 2023
6 checks passed
@bjarnef bjarnef deleted the feature/input-type-search branch November 27, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants