Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes LastLockOut DateTime value #16833

Closed

Conversation

KudAndrii
Copy link

issue:
#16761

If there's an existing issue for this PR then this fixes

Description:
IMembershipUser.LastLockoutDate is set as DateTime, value is equal to the server offset time but kind of it equal to UTC

Testing:
enter wrong password needed amount of times to be locked out, and you will be locked out till the DateTime which will be calculated as the following:
IMembershipUser.LastLockoutDate + MemberDefaultLockoutTimeInMinutes
but as far as IMembershipUser.LastLockoutDate is set (or parsed) incorrectly, any minutes you specify in the MemberDefaultLockoutTimeInMinutes will be added to your server offset

Copy link

github-actions bot commented Jul 27, 2024

Hi there @KudAndrii, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@KudAndrii
Copy link
Author

JasonElkin as you asked, the new pr is open
your_comment

@KudAndrii KudAndrii mentioned this pull request Jul 27, 2024
@JasonElkin JasonElkin changed the base branch from v13/contrib to contrib July 29, 2024 11:29
@JasonElkin JasonElkin changed the base branch from contrib to v13/contrib July 29, 2024 11:29
@JasonElkin JasonElkin self-assigned this Jul 29, 2024
@JasonElkin
Copy link
Contributor

Thanks @KudAndrii, we'll get this reviewed and get back to you soon.

@emmagarland emmagarland changed the title Issue #16761 Fixes LastLockOut DateTime value Aug 9, 2024
@JasonElkin
Copy link
Contributor

JasonElkin commented Aug 20, 2024

Hi there @KudAndrii, thanks for taking a look at this.

Mapping methods shouldn't make changes to source objects, so we can't make this change here.

#16761 is part of a bigger problem with how DateTimes are stored and retrieved from the database (#16125), and needs to either be fixed alongside it or account for a fix to it.

In the meantime running Umbraco on a server with a UTC time zone (as is often recommended for production web servers and is the default for Azure and Umbraco Cloud) will fix the problem.

Thanks again,
Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants