Clean up Processed local image links in Management api (#16828)

* Removed type attribute from processed local links improved code readabilty by using multi return type to private class * Removed type attribute from processed locallinks in delivery api * Removed type attribute from expected output regarding locallink parsing * Added type atttribute removal in deliveryapi for local image link and invalid local links Test rename for clarity and
umbraco · Jul 29, 2024 · f807960 · f807960
1 parent ceb86b6
commit f807960
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParser.cs b/src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParser.cs
@@ -62,8 +62,16 @@ private void ReplaceLocalLinks(HtmlDocument doc, IPublishedSnapshot publishedSna
                     link.SetAttributeValue("data-start-item-id", route.StartItem.Id.ToString("D"));
                     link.Attributes["type"]?.Remove();
                 },
-                url => link.SetAttributeValue("href", url),
-                () => link.Attributes.Remove("href"));
+                url =>
+                {
+                    link.SetAttributeValue("href", url);
+                    link.Attributes["type"]?.Remove();
+                },
+                () =>
+                {
+                    link.Attributes.Remove("href");
+                    link.Attributes["type"]?.Remove();
+                });
         }
     }
 

diff --git a/...mbraco.Tests.UnitTests/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParserTests.cs b/...mbraco.Tests.UnitTests/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParserTests.cs
@@ -81,7 +81,7 @@ public void Can_Parse_LocalLinks()
     }
 
     [Test]
-    public void Can_Parse_Legacy_LocalImages()
+    public void Can_Parse_Inline_LocalImages()
     {
         var key1 = Guid.Parse("395bdc0e8f4d4ad4af7f3a3f6265651e");
         var data1 = new MockData()