Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to Svelte 5 and update Lexical dependency to 0.20 #101

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

fokx
Copy link

@fokx fokx commented Nov 26, 2024

This PR contains various commits:

  • update lexical related dependencies to latest version(0.20)
  • migrate to Svelte 5 using pnpx sv migrate svelte-5 and manually fix some errors

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-lexical ❌ Failed (Inspect) Nov 28, 2024 5:55am
svelte-lexical-playground ❌ Failed (Inspect) Nov 28, 2024 5:55am

@umaranis
Copy link
Owner

Thanks for the PR @fokx

Let me review and get back to you.

@umaranis
Copy link
Owner

About 8 tests are failing, mainly related to Images.

I get the following when trying to add an image.
image

@umaranis
Copy link
Owner

umaranis commented Nov 27, 2024

Also, svelte-check finds 64 errors and 6 warnings in svelte-lexical package (there are also errors in other packages).

Upgrades to lexical 20 and svelte 5 are major changes and I would suggest to keep them separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants