bug: return unregister callback from onMount

umaranis · May 6, 2024 · 3e82f9b · 3e82f9b
1 parent 8e959d5
commit 3e82f9b
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/packages/svelte-lexical/src/lib/components/toolbar/RedoButton.svelte b/packages/svelte-lexical/src/lib/components/toolbar/RedoButton.svelte
@@ -20,7 +20,7 @@
 
   // unregisters onDestroy through returned callback
   onMount(() => {
-    editor.registerCommand(
+    return editor.registerCommand(
       CAN_REDO_COMMAND,
       (payload) => {
         canRedo = payload;

diff --git a/packages/svelte-lexical/src/lib/components/toolbar/StateStoreRichTextUpdator.svelte b/packages/svelte-lexical/src/lib/components/toolbar/StateStoreRichTextUpdator.svelte
@@ -139,7 +139,7 @@
 
   // unregisters onDestory using returned callback
   onMount(() => {
-    mergeRegister(
+    return mergeRegister(
       editor.registerUpdateListener(({editorState}) => {
         editorState.read(() => {
           updateToolbar();

diff --git a/packages/svelte-lexical/src/lib/components/toolbar/UndoButton.svelte b/packages/svelte-lexical/src/lib/components/toolbar/UndoButton.svelte
@@ -20,7 +20,7 @@
 
   // unregisters onDestroy through returned callback
   onMount(() => {
-    editor.registerCommand(
+    return editor.registerCommand(
       CAN_UNDO_COMMAND,
       (payload) => {
         canUndo = payload;

diff --git a/packages/svelte-lexical/src/lib/core/ContentEditable.svelte b/packages/svelte-lexical/src/lib/core/ContentEditable.svelte
@@ -38,7 +38,7 @@
     }
 
     isEditable = editor.isEditable();
-    editor.registerEditableListener((currentIsEditable) => {
+    return editor.registerEditableListener((currentIsEditable) => {
       isEditable = currentIsEditable;
     });
   });

diff --git a/packages/svelte-lexical/src/lib/core/plugins/HorizontalRulePlugin.svelte b/packages/svelte-lexical/src/lib/core/plugins/HorizontalRulePlugin.svelte
@@ -15,7 +15,7 @@
   const editor = getEditor();
 
   onMount(() => {
-    editor.registerCommand(
+    return editor.registerCommand(
       INSERT_HORIZONTAL_RULE_COMMAND,
       (type) => {
         const selection = getSelection();

diff --git a/packages/svelte-lexical/src/lib/core/plugins/MardownShortcut/MarkdownShortcutPlugin.svelte b/packages/svelte-lexical/src/lib/core/plugins/MardownShortcut/MarkdownShortcutPlugin.svelte
@@ -81,6 +81,6 @@
   ];
 
   onMount(() => {
-    registerMarkdownShortcuts(editor, TRANSFORMERS);
+    return registerMarkdownShortcuts(editor, TRANSFORMERS);
   });
 </script>