Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book version fix #110

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Book version fix #110

merged 2 commits into from
Apr 29, 2024

Conversation

j-c-gibson
Copy link
Collaborator

Updating requirements so that jupyter book version 0.15.0 (requires Python >=3.7) is specified. Will hopefully get the build-book workflow to complete.

TODO: requirements.txt present in root folder and in docs. Probably redundant to pip install them both in book.yml.

@j-c-gibson j-c-gibson requested a review from twomagpi April 26, 2024 09:58
Copy link
Collaborator

@twomagpi twomagpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be quite so specific on the docutils version?

I.e. could we use docutils >= 0.17.1 ?

@twomagpi twomagpi dismissed their stale review April 29, 2024 09:47

Docutils has a citations bug. Currently best to use a pinned version pinned at 0.17.1

Copy link
Collaborator

@twomagpi twomagpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with a specific version requirement for jupyter-book

@twomagpi twomagpi merged commit 303ef5d into master Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants