Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LineRange and LineRangeList from analysis-model #815

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Sep 21, 2023

Since these classes could be used in the coverage model as well, it makes sense to move them to this project.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage is 75.15% of modified lines.

Files Changed Coverage
...rc/main/java/edu/hm/hafner/util/LineRangeList.java 74.80%
src/main/java/edu/hm/hafner/util/LineRange.java 76.92%

📢 Thoughts on this report? Let us know!.

* if some property of an element of the specified collection prevents it from being added to this list
* @see #add(Object)
*/
public final boolean addAll(final Iterable<? extends LineRange> ranges) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method LineRangeList.addAll(..) could be confused with overloaded method
addAll
, since dispatch depends on static types.
* @author Kohsuke Kawaguchi
* @author Ullrich Hafner
*/
class LineRangeListTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note test

Unused class: LineRangeListTest is not referenced within this codebase. If not used as an external API it should be removed.
@uhafner uhafner merged commit 96a8303 into main Sep 28, 2023
28 of 30 checks passed
@uhafner uhafner deleted the line-range branch September 28, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant