Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new profile that disables build failures in CI #1011

Merged
merged 1 commit into from
May 6, 2024
+16 −5
Merged

Create a new profile that disables build failures in CI #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
- name: Build with Maven
env:
BROWSER: chrome-container
run: mvn -V --color always -ntp clean verify --file pom.xml '-Djenkins.test.timeout=5000' '-Dgpg.skip'
run: mvn -V --color always -ntp clean verify --file pom.xml '-Djenkins.test.timeout=5000' '-Dgpg.skip' -Pci
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
maven-version: 3.9.6
- name: Generate coverage with JaCoCo
run: mvn -V --color always -ntp clean verify '-Dgpg.skip'
run: mvn -V --color always -ntp clean verify '-Dgpg.skip' -Pci
- name: Upload coverage to Codecov
uses: codecov/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/quality-monitor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Build with Maven
env:
BROWSER: chrome-container
run: mvn -V --color always -ntp clean verify -Ppit | tee maven.log
run: mvn -V --color always -ntp clean verify -Ppit -Pci | tee maven.log
- name: Extract pull request number
uses: jwalton/gh-find-current-pr@v1
id: pr
Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ node('java-agent') {

stage ('Build, Test, and Static Analysis') {
withMaven(mavenLocalRepo: '/var/data/m2repository', mavenOpts: '-Xmx768m -Xms512m') {
sh 'mvn -V -e clean verify -Dmaven.test.failure.ignore -Dgpg.skip -Drevapi.skip'
sh 'mvn -V -e clean verify -Dgpg.skip -Pci'
}

recordIssues tools: [java(), javaDoc()], aggregatingResults: 'true', id: 'java', name: 'Java'
Expand Down
13 changes: 12 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,10 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<configuration>
<failOnError>false</failOnError>
<failOnError>true</failOnError>
<xmlOutput>true</xmlOutput>
<threshold>Low</threshold>
<failThreshold>Low</failThreshold>
<effort>Max</effort>
<relaxed>false</relaxed>
<fork>true</fork>
Expand All @@ -694,6 +695,7 @@
<id>run-spotbugs</id>
<goals>
<goal>spotbugs</goal>
<goal>check</goal>
</goals>
<phase>verify</phase>
</execution>
Expand Down Expand Up @@ -875,6 +877,15 @@
<spotbugs.skip>true</spotbugs.skip>
</properties>
</profile>
<profile>
<id>ci</id>
<properties>
<maven.test.failure.ignore>true</maven.test.failure.ignore>
<checkstyle.failOnViolation>false</checkstyle.failOnViolation>
<pmd.failOnViolation>false</pmd.failOnViolation>
<spotbugs.maxAllowedViolations>10000000</spotbugs.maxAllowedViolations>
</properties>
</profile>
<profile>
<id>pit</id>
<build>
Expand Down