Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the default invocation of pmd when using the check goal #1009

Merged
merged 1 commit into from
May 3, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented May 3, 2024

When we apply the different PMD rulesets guide in combination with the maven check goal then PMD is invoked three times: one time for the production code, one time for the test code, and one time for the check goal with the default configuration. The last invocation makes no sense and needs to be removed so that additional pipeline scripts correctly visualize the PMD results.

@uhafner uhafner added the bug Bugs or performance problems label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

☀️   Quality Monitor

   🚦   Tests: 98 % successful (✔️ 95 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (62 missed lines)
   ➰   Branch Coverage: 92% (19 missed branches)
   PIT   Mutation Coverage: 80% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings found
   PMD   PMD: 3 warnings found (0 error, 0 high, 3 normal, 0 low)
   SpotBugs   SpotBugs: No warnings found

Created by Quality Monitor v1.8.2 (#d626b05). More details are shown in the GitHub Checks Result.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (fd2edcf) to head (6a7e85f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1009   +/-   ##
=========================================
  Coverage     88.98%   88.98%           
  Complexity      181      181           
=========================================
  Files            11       11           
  Lines           717      717           
  Branches         93       93           
=========================================
  Hits            638      638           
  Misses           62       62           
  Partials         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit d3fcf16 into main May 3, 2024
31 checks passed
@uhafner uhafner deleted the skip-pmd-default branch May 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant