Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication/dataset detail page sidebar #1663

Open
verheyenkoen opened this issue Jul 18, 2024 · 13 comments · May be fixed by #1682
Open

Publication/dataset detail page sidebar #1663

verheyenkoen opened this issue Jul 18, 2024 · 13 comments · May be fixed by #1682
Assignees

Comments

@verheyenkoen
Copy link
Contributor

verheyenkoen commented Jul 18, 2024

Enhancement

Add an icon sidebar on the right side in detail pages with 2 icons that open/toggle a drawer when clicked.

  • Biblio messages

    • Biblio message
    • Librarian tags (librarian only)
    • Librarian note (librarian only)
    image
  • Add a "dot" to Biblio messages menu item when there is a message added to the Biblio message field.
    No need to add a "new message" state. The dot can be shown if the input field is "dirty".

  • Details

Screenshot 2024-10-01 at 11 47 20
  • Activity history
    • We can already display the information we have, and extend later.
Screenshot 2024-10-01 at 11 47 33
  • remember whether the sidebar was opened or locked across records

Prototype

@verheyenkoen verheyenkoen added the enhancement New feature or request label Jul 18, 2024
@verheyenkoen verheyenkoen self-assigned this Jul 18, 2024
@mietcls
Copy link
Member

mietcls commented Jul 18, 2024

Added:

  • librarian tags
  • librarian note

Suggestion for save: buttons for now until we have a coherent approach to saving everywhere (otherwise we will have different patterns which will be confusing).

Screenshot 2024-07-18 at 12 12 19

@mietcls
Copy link
Member

mietcls commented Jul 18, 2024

Q: Can we remember whether the message tab was opened or closed by default?

@verheyenkoen
Copy link
Contributor Author

Q: Can we remember whether the message tab was opened or closed by default?

@verheyenkoen verheyenkoen changed the title Add publication/dataset detail page sidebar Publication/dataset detail page sidebar Jul 18, 2024
@verheyenkoen verheyenkoen linked a pull request Sep 26, 2024 that will close this issue
@verheyenkoen
Copy link
Contributor Author

@nics I started this a couple of weeks ago but very quickly bumped into the fact that this is needed for both publications and datasets so the question is: is there something we can do to make sure we don't have to build the sidebar twice? We talked about deduping other views but never took any steps AFAIK. I guess it would be good to finally kick this off before we create any new duplicate views.

@nics
Copy link
Member

nics commented Sep 26, 2024

@verheyenkoen you can dedup them if it isn't too much work. The next version combines Publication and Dataset into Work, so it's not worth it duplicating all that effort here.

@verheyenkoen
Copy link
Contributor Author

@nics I guess my question wasn't clear. How do we do that? I guess we need some kind of common structure for publications and datasets for that to be possible but I don't know how to achieve a base interface in Go that can be both. As I don't really know how this is done, I can't really estimate the effort for that.

@nics
Copy link
Member

nics commented Sep 26, 2024

That was my point, making a common interface isn't worth the effort now, the next version already solves that. But if you can easily avoid some duplication now by making the url configurable and passing a common args to the template, then go ahead.

@verheyenkoen
Copy link
Contributor Author

But I guess that requires mapping the common fields on a new struct type before passing it to the view?

@verheyenkoen
Copy link
Contributor Author

  • Add a "dot" to Biblio messages menu item when there is a message added to the Biblio message field.

@nics Is this something we can achieve with the current Biblio? We can compare the message with previous snapshots but I don't think we have a way to log who has already seen this change (unless in local storage).

@nics
Copy link
Member

nics commented Oct 1, 2024

  • Add a "dot" to Biblio messages menu item when there is a message added to the Biblio message field.

@nics Is this something we can achieve with the current Biblio? We can compare the message with previous snapshots but I don't think we have a way to log who has already seen this change (unless in local storage).

Not efficiently no, better to postpone this.

@verheyenkoen
Copy link
Contributor Author

@mietcls I think we're gonna need some kind of loading-feedback when you click one of the save buttons. In the current version you see the popup close when the save is complete but in the sidebar, if the save succeeds nothing appears to be happening which may cause confusion.

@mietcls
Copy link
Member

mietcls commented Oct 9, 2024

Thanks for noticing, I'll make something @verheyenkoen

@mietcls
Copy link
Member

mietcls commented Oct 11, 2024

Discussion yesterday:
Saving behaviour in the modals in the detail panel VS the save buttons in the side panel: might result into information loss.

@verheyenkoen can you confirm / add any thoughts?

  • Option 1: We assume people have to save the side panel changes.

    • Upside:
      • it's already a few clicks less than the Biblio messages tab
      • it's consequent behaviour
    • Downside: if they open a detail panel modal and click save, without saving the edits they made in the side panel, the edits in the side panel will disappear be lost.
  • Option 1.1: We explicitly ask on blur whether the user wants to undo the changes they made.

    • Upside: we make consequences explicit.
    • Downside:
      • A lot of small tweaking = a lot of maintenance.
      • Requires customisation we might throw out.
  • Option 2: We autosave whatever happens in the Biblio messages, librarian tags an librarian notes

    • Upside: there will be no saving issue
    • Downside: our saving behaviour will differ in the application, causing mixed expectations which can cause frustration.
      • There is no autosave anywhere else. This is introducing different behaviour in one application, which can result in different problems.
      • Introducing autosave is not ideal right now. If we are going to tackle the full page, we might land on different behaviour, and taking that away afterwards is going to be hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog (to be prioritised) 🪵
Development

Successfully merging a pull request may close this issue.

3 participants