Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/frontend not shown #119

Closed
wants to merge 1 commit into from
Closed

bugfix/frontend not shown #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/manifests/frontend/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ spec:
image: ghcr.io/ueckoken/plarail2021-soft-frontend:b897376-1637561920 # {"$imagepolicy": "plarail2021:frontend"}
Copy link
Member

@Azuki-bar Azuki-bar Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、去年のイメージ見ているからじゃないですか？
確かにイメージが公開するポートを変更したので一緒にマニフェストも変更した(#28 )のですが、ここは去年を見ているのでイメージが公開するポートの変更に追従できなかったものと考えられます。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現状の2022最新イメージ(dee27aa)から作成されるイメージは8080を公開しています。
ですのでイメージ名を変更することによって修正できると思います。

imagePullPolicy: Always
ports:
- containerPort: 8080
- containerPort: 80
2 changes: 1 addition & 1 deletion manifests/manifests/frontend/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ spec:
ports:
- port: 80
protocol: TCP
targetPort: 8080
targetPort: 80