Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

レース編集UIを実装 #231

Merged
merged 9 commits into from
Oct 23, 2022
Merged

レース編集UIを実装 #231

merged 9 commits into from
Oct 23, 2022

Conversation

hutinoatari
Copy link
Member

@hutinoatari hutinoatari commented Oct 20, 2022 •
edited by Azuki-bar
Loading

ref #108 #151

@github-actions github-actions bot added the PB label Oct 20, 2022
@hutinoatari
Copy link
Member Author

membersをuint32[](馬idの配列)にした
RaceDetail.Memberだと順位はResisterRaceResult、オッズと人気はサーバー側で計算するものでこちら側から値を出せないため

@hutinoatari hutinoatari requested a review from Azuki-bar October 20, 2022 19:20
@github-actions github-actions bot added backend documentation Improvements or additions to documentation labels Oct 22, 2022
@Azuki-bar
Copy link
Member

RaceDetailはオッズ（odds）や人気（popularity）を保持し、またそれらの値が含まれることをバリデータにて保証していたが、Raceの登録は開催前に行いこれらの値を登録することはできないためバリデータを破壊

@hutinoatari hutinoatari merged commit 26bde38 into main Oct 23, 2022
@hutinoatari hutinoatari deleted the fix-register-page branch October 23, 2022 12:42
@github-actions github-actions bot mentioned this pull request Oct 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azuki-bar Azuki-bar Awaiting requested review from Azuki-bar

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation frontend PB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hutinoatari @Azuki-bar