Fix Circular Dependency between Service and Module

ueberfuhr · Oct 20, 2022 · 9f1c4f9 · 9f1c4f9
1 parent 3df6986
commit 9f1c4f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/projects/gitlab-client/src/lib/gitlab-client.module.ts b/projects/gitlab-client/src/lib/gitlab-client.module.ts
@@ -10,6 +10,7 @@ import {GitlabLabelsService} from './issues/gitlab-labels.service';
 import {IssueImportService} from './issues/issue-import.service';
 import {IssueExportService} from './issues/issue-export.service';
 import {IssueExportModelMapperService} from './issues/issue-export-model-mapper.service';
+import {ProgressService} from './issues/progress/progress.service';
 
 /**
  * Use this injection token to configure a Gitlab connection configuration provider.
@@ -82,7 +83,8 @@ export const GITLAB_CONFIG_PROVIDER = new InjectionToken<() => GitlabConfig>("Gi
     GitlabIssuesService,
     IssueExportModelMapperService,
     IssueImportService,
-    IssueExportService
+    IssueExportService,
+    ProgressService
   ],
   declarations: [
     LabelsByNamePipe

diff --git a/projects/gitlab-client/src/lib/issues/progress/progress.service.ts b/projects/gitlab-client/src/lib/issues/progress/progress.service.ts
@@ -1,14 +1,13 @@
 import {Injectable, Optional} from '@angular/core';
 import {BehaviorSubject, defer, Observable, of, tap} from 'rxjs';
-import {GitlabClientModule} from '../../gitlab-client.module';
 
 export abstract class ProgressDialog {
 
   abstract open(param: { data: { mode: "determinate" | "indeterminate" | undefined; title: string | undefined; status: Observable<ProgressStatus> }; disableClose: boolean }): void;
 }
 
 @Injectable({
-  providedIn: GitlabClientModule
+  providedIn: null
 })
 export class ProgressService {