-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start #30
Closed
Closed
Start #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionally added a Bookshelve for presenting something on the page
The actual move is not yet implemented.
- css adjusted for the select-image - books are stored in their own shelf array - moveBookToShelf method introduced
- BrowserRouter, Routes, Route and Link added from react-router-dom - Separate page created for MyReads and Search - A book may now be added or moved to a shelf -
…d on the page. - addBookToShelf is also called after moving a book to another shelf
Only one state for books is kept in the app.js. Each shelf now shows only the books for that shelf.
No separate methods for moving and adding books are passed to components.
…API to search - boyscout: variables extracted - method 'storeBookOnShelf' no longer directly used
…h page, the previous search results are shown
Review comments processed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission to udacity