Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start #30

Closed
wants to merge 17 commits into from
Closed

Start #30

wants to merge 17 commits into from

Conversation

benshoe
Copy link

@benshoe benshoe commented Oct 18, 2023

Submission to udacity

additionally added a Bookshelve for presenting something on the page
The actual move is not yet implemented.
- css adjusted for the select-image
- books are stored in their own shelf array
- moveBookToShelf method introduced
- BrowserRouter, Routes, Route and Link added from react-router-dom
- Separate page created for MyReads and Search
- A book may now be added or moved to a shelf
-
…d on the page.

- addBookToShelf is also called after moving a book to another shelf
Only one state for books is kept in the app.js. Each shelf now shows only the books for that shelf.
No separate methods for moving and adding books are passed to components.
@benshoe benshoe requested a review from a team as a code owner October 18, 2023 17:53
@benshoe benshoe requested review from SudKul and removed request for a team October 18, 2023 17:53
@benshoe
Copy link
Author

benshoe commented Oct 31, 2023

Review comments processed.

@benshoe benshoe closed this Oct 31, 2023
@benshoe benshoe deleted the start branch October 31, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant