Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar update #6

Closed
wants to merge 23 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d19a351
Chore: setup dev env
arth-shukla Apr 12, 2023
270e6e8
Progress: add thumbnail grid
arth-shukla Apr 12, 2023
33661a2
Progress: skip button with simple scroll checking
arth-shukla Apr 12, 2023
535bb5d
Progress: animate button + a11y
arth-shukla Apr 12, 2023
dd5b2c3
Feat: finish showcase structure
arth-shukla Apr 12, 2023
2374830
Fix: attempt to allow gh package registry installs
arth-shukla Apr 13, 2023
dbc7b81
Fix: remove component library, move component to components folder
arth-shukla Apr 13, 2023
81f03dc
Fix: match section padding with navbar/footer
aaronchan32 Apr 13, 2023
54455fa
Feat: add (optional) ext link support
arth-shukla Apr 13, 2023
0066cec
Fix: keys regen -> unnecessary rerenders
arth-shukla Apr 13, 2023
b4f2bfa
Fix: semantic html, font sizing
arth-shukla Apr 13, 2023
689587c
Fix: h2 padding bottom
arth-shukla Apr 13, 2023
496ecc6
Trivial: thumbnail img hover anim
arth-shukla Apr 14, 2023
b60a402
Fix: button under images
arth-shukla Apr 14, 2023
83e5271
Fix: add bold styling to active page
aaronchan32 Apr 14, 2023
e77c7b2
Fix: add active styling to arrow-down
aaronchan32 Apr 14, 2023
4c9b369
Fix: centered button text and add active state
aaronchan32 Apr 14, 2023
05dd94f
Fix: use brightness() for dimming
arth-shukla Apr 14, 2023
ead788d
Feat: add showcase to navbar
aaronchan32 Apr 16, 2023
901e53f
Fix: make showcase default home page
aaronchan32 Apr 16, 2023
bf0cfe7
Fix: fix imports
aaronchan32 Apr 16, 2023
6c1875b
Fix: make mobile navbar reflect desktop navbar
aaronchan32 Apr 16, 2023
b613312
Fix: update mobile overflow when navigating
aaronchan32 Apr 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,7 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*

.prettierrc
.vscode
.npmrc
63,905 changes: 31,920 additions & 31,985 deletions package-lock.json

Large diffs are not rendered by default.

81 changes: 41 additions & 40 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,42 +1,43 @@
{
"name": "vda",
"version": "0.1.0",
"private": true,
"dependencies": {
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"framer-motion": "^8.1.7",
"node-sass": "^8.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-grid-system": "^8.1.6",
"react-router-dom": "^6.6.1",
"react-scripts": "5.0.1",
"web-vitals": "^2.1.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
"name": "vda",
"version": "0.1.0",
"private": true,
"dependencies": {
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"framer-motion": "^8.1.7",
"node-sass": "^8.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-grid-system": "^8.1.6",
"react-router-dom": "^6.6.1",
"react-scripts": "5.0.1",
"react-uuid": "^2.0.0",
"web-vitals": "^2.1.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
}
58 changes: 32 additions & 26 deletions src/App.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,40 @@
import { useEffect } from "react";
import {
BrowserRouter as Router,
Route,
Routes,
useLocation,
} from "react-router-dom";
import Home from "./pages/home";
import ProgramOverview from "./pages/programOverview";
import { useEffect } from 'react'
import { BrowserRouter as Router, Route, Routes, useLocation } from 'react-router-dom'
import Home from './pages/about'
import ProgramOverview from './pages/programOverview'
import Showcase from './pages/home'

const ScrollToTop = () => {
const { pathname } = useLocation();
const { pathname } = useLocation()

useEffect(() => {
window.scrollTo(0, 0);
}, [pathname]);
useEffect(() => {
window.scrollTo(0, 0)
}, [pathname])

return null;
};
return null
}

function App() {
return (
<Router>
{" "}
<ScrollToTop />
<Routes>
<Route path="/" element={<Home />} />
<Route path="/program-overview" element={<ProgramOverview />} />
</Routes>
</Router>
);
return (
<Router>
{' '}
<ScrollToTop />
<Routes>
<Route
path='/'
element={<Showcase />}
/>
<Route
path='/program-overview'
element={<ProgramOverview />}
/>
<Route
path='/about'
element={<Home />}
/>
</Routes>
</Router>
)
}

export default App;
export default App
50 changes: 5 additions & 45 deletions src/components/landing/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,7 @@ import WhiteStar from '../../assets/images/home/star-white.png';
import {motion} from 'framer-motion'
import './styles.scss';

function Landing() {

const messagesArray = [
{line: "12 weeks (Jan 23 - Apr 14, 2023)",},
{line: "3-6 hr commitment per week",},
{line: "Hands-on practice in visual design",},
{line: "Peer feedback and support",}
];

const messagesArray2 = [
{line: "A few solid portfolio pieces + a brand case study that can be presented in interviews",},
{line: "Experience working on brand identity, print design, UI design, social media graphics, and more",}
];
function Landing({description, button=null}) {

return (
<div className='landing'>
Expand Down Expand Up @@ -67,15 +55,12 @@ function Landing() {

<div className='grid-child-text'>
<h2>VISUAL DESIGN APPRENTICESHIP</h2>
<div className='grid-child-text-inner'>
<p className='justify'>
Design Co’s first ever Visual Design Apprenticeship is a 12-week long
program where student designers will work on a variety of hands-on
assignments focusing on visual, graphic, and brand design. <br></br><br></br>
Students will learn fundamental techniques in Adobe and Figma through
in-person lessons and will have the opportunity to participate in
critique sessions, work sessions, and accountability buddy groups! This
is NOT a UX-based program.
{description}
</p>
{button}
</div>
</div>

<div className='grid-child-img'>
Expand All @@ -84,31 +69,6 @@ function Landing() {

</div>

<div className='grid-container2'>

<div className='grid-child-orange2'>
{messagesArray.map((message) => (
<div className='response-container'>
<img src={BlackStar} />
<p>{message.line}</p>
</div>
))}
</div>

<div className='grid-child-text'>
<h3>
By the end of the program, apprentices will be equipped with:
</h3>
<div className='bottom-container'>
{messagesArray2.map((message) => (
<div className='response-container'>
<img src={WhiteStar} />
<p>{message.line}</p>
</div>
))}
</div>
</div>
</div>
</div>
)
}
Expand Down
18 changes: 15 additions & 3 deletions src/components/landing/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,20 @@ body {
display: grid;
grid-template-columns: 1fr 1fr;

@media only screen and (max-width: $mobile) {
grid-template-columns: 1fr;
@media only screen and (max-width: 800px) {
grid-template-columns: 1fr !important;
}

.justify {
text-align: justify;
}

.grid-child-img {
@media only screen and (max-width: $mobile) {

@media only screen and (max-width: 800px) {
display: none;
}

}

.green-blob {
Expand All @@ -101,8 +103,18 @@ body {
}

.grid-child-text {
&-inner {
padding-right: 20%;

}
padding: 4rem 8vw;

@media only screen and (max-width: 1200px) {
&-inner {
padding-right: 0;
}
}

@media only screen and (max-width: $mobile) {
padding: 2.5rem 8vw;
}
Expand Down
56 changes: 56 additions & 0 deletions src/components/landingLogistics/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import React from 'react';
import DesignCo from '../../assets/images/home/dco-logo.png';
import VDA from '../../assets/images/home/vda-black.png';
import Green from '../../assets/images/home/green-blob.png';
import BlackStar from '../../assets/images/home/star-black.png';
import WhiteStar from '../../assets/images/home/star-white.png';
import {motion} from 'framer-motion'
import './styles.scss';

function LandingLogistics() {

const messagesArray = [
{line: "12 weeks (Jan 23 - Apr 14, 2023)",},
{line: "3-6 hr commitment per week",},
{line: "Hands-on practice in visual design",},
{line: "Peer feedback and support",}
];

const messagesArray2 = [
{line: "A few solid portfolio pieces + a brand case study that can be presented in interviews",},
{line: "Experience working on brand identity, print design, UI design, social media graphics, and more",}
];

return (
<div className='landing'>

<div className='grid-container2'>

<div className='grid-child-orange2'>
{messagesArray.map((message) => (
<div className='response-container'>
<img src={BlackStar} />
<p>{message.line}</p>
</div>
))}
</div>

<div className='grid-child-text'>
<h3>
By the end of the program, apprentices will be equipped with:
</h3>
<div className='bottom-container'>
{messagesArray2.map((message) => (
<div className='response-container'>
<img src={WhiteStar} />
<p>{message.line}</p>
</div>
))}
</div>
</div>
</div>
</div>
)
}

export default LandingLogistics;
Loading