Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Functionality and Styling For Themes Page #9

Closed
wants to merge 10 commits into from

Conversation

EdwardNew
Copy link
Member

✨ Tracking

Working Towards Resolves Issue #4 (mostly done, needs some polishing)

🌱 Changes

  • Added keen-slider package
  • Added ThemesSlider and ThemeSlide components for mobile slider
  • Added Table to Themes page for desktop layout
  • Added styling to all components

📝 Testing

  • Tested on Chrome, Firefox, and only Safari on mobile
  • Tested basic keyboard accessibility of slider

💻 Did you test on all browsers?

  • Yes
  • No

🐛 Known Bugs

  • Desktop section overflows if screen screen size is short/narrow enough
    image
  • Slider has a brief layout shift on reload
    image

🔮 Future Features

  • Considering refactoring the ThemesSlider component to be more general Slider component

📷Screenshots

image
image

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
up-grade24 ✅ Ready (Inspect) Visit Preview 1 resolved Jun 2, 2024 1:43am

@EdwardNew EdwardNew changed the title Page/edward new/themes page Base Functionality and Styling For Themes Page May 21, 2024
…t, add slide navigation arrow buttons for screen sizes smaller than desktop
@IndiSnacks
Copy link
Contributor

Looks solid! I think you're good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants