Fixed issue #3955 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected "Échec de la connection" to "Échec de la connexion"
`check_pid` returns `True` if the PID for a notebook server still exists. Therefore, the `if check_pid(pid):` statements on lines 424 and 437 evaluate to `True` even though the notebook server is still running. This commit simply adds a `not` to each line: `if not check_pid(pid):` so that the conditional only evaluates to `True` if `check_pid` returns `False`, which happens when the notebook server has shutdown, as expected.
…o see whether this is sufficient
…dit,View,Insert,Cell...etc)present on the menubar.
…rnbaccessibility/notebook into issue-acc-overwrite
The most recent release of preact-compat appears to have broken notebook.
…er#4576) If the message is bytes, we should set binary=True This is a port from NB2KG PR jupyter/nb2kg#33
The connect and request timeout defaults have been updated from 20 to 60 seconds and a default value of 40 has been added for KERNEL_LAUNCH_TIMEOUT. The code ensures that KERNEL_LAUNCH_TIMEOUT is in the env and that the value of the request timeout is at least 2 greather than KERNEL_LAUNCH_TIMEOUT. This PR is port of the NB2KG PRs 35 and 38.
The new CSS styles have been released with notebook 5.0.0 in March 2017.
…ues-3998/3971/3968 Solved issues jupyter#3998, jupyter#3971 and jupyter#3968
- increased `smalltooltip` height to 85px to account for padding in `tooltiptext` - reduced `ui-button` dimensions in tooltip and pager
Populate changelog based on commit history and some new functionality described on 5.x release notes including a section for security fixes.
We were missing a yield statement in the deferral of `get()` to the superclass. This issue was occurring only when Tornado 6+ was deployed. Also removed a debug message producing way too much information.
I removed the mirroring 'Receiving' debug statement previously and didn't realize there's a 'Sending' statement. This change removes that statement. This should be part of the 6.0 release, just not signficant enough to warrant include in rc1.
Switch from preact to react
Remove verbose debug statement in gateway mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sort buttons accessible by keyboard: Fixed issue jupyter#3955