Fixes issue jupyter#3939, jupyter#3958

uclixnjupyternbaccessibility · Jun 20, 2019 · b02c05c · b02c05c
1 parent fe8156b
commit b02c05c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/notebook/static/notebook/js/codecell.js b/notebook/static/notebook/js/codecell.js
@@ -178,7 +178,7 @@ define([
             cell: this, 
             notebook: this.notebook});
         inner_cell.append(this.celltoolbar.element);
-        var input_area = $('<div/>').addClass('input_area');
+        var input_area = $('<div/>').addClass('input_area').attr("aria-label", "Edit code here");
         this.code_mirror = new CodeMirror(input_area.get(0), this._options.cm_config);
         // In case of bugs that put the keyboard manager into an inconsistent state,
         // ensure KM is enabled when CodeMirror is focused:

diff --git a/notebook/static/notebook/js/notebook.js b/notebook/static/notebook/js/notebook.js
@@ -1216,7 +1216,7 @@ define([
         // This will put all the deleted cells back in one location, rather than
         // where they came from. It will do until we have proper undo support.
         undelete_backup.index = cursor_ix_after;
-        $('#undelete_cell').removeClass('disabled');
+        $('#undelete_cell').removeClass('disabled').removeAttr("aria-label");
 
         this.undelete_backup_stack.push(undelete_backup);
         this.set_dirty(true);
@@ -1622,13 +1622,13 @@ define([
         if (!this.paste_enabled) {
             $('#paste_cell_replace').removeClass('disabled')
                 .on('click', function () {that.keyboard_manager.actions.call(
-                    'jupyter-notebook:paste-cell-replace');});
+                    'jupyter-notebook:paste-cell-replace');}).removeAttr("aria-label");
             $('#paste_cell_above').removeClass('disabled')
                 .on('click', function () {that.keyboard_manager.actions.call(
-                    'jupyter-notebook:paste-cell-above');});
+                    'jupyter-notebook:paste-cell-above');}).removeAttr("aria-label");
             $('#paste_cell_below').removeClass('disabled')
                 .on('click', function () {that.keyboard_manager.actions.call(
-                    'jupyter-notebook:paste-cell-below');});
+                    'jupyter-notebook:paste-cell-below');}).removeAttr("aria-label");
             this.paste_enabled = true;
         }
     };
@@ -1938,7 +1938,7 @@ define([
      */
     Notebook.prototype.enable_attachments_paste = function () {
         if (!this.paste_attachments_enabled) {
-            $('#paste_cell_attachments').removeClass('disabled');
+            $('#paste_cell_attachments').removeClass('disabled').removeAttr("aria-label");
             this.paste_attachments_enabled = true;
         }
     };
@@ -1948,7 +1948,7 @@ define([
      */
     Notebook.prototype.set_insert_image_enabled = function(enabled) {
         if (enabled) {
-            $('#insert_image').removeClass('disabled');
+            $('#insert_image').removeClass('disabled').removeAttr("aria-label");
         } else {
             $('#insert_image').addClass('disabled');
         }

diff --git a/notebook/static/notebook/js/textcell.js b/notebook/static/notebook/js/textcell.js
@@ -98,7 +98,7 @@ define([
             cell: this, 
             notebook: this.notebook});
         inner_cell.append(this.celltoolbar.element);
-        var input_area = $('<div/>').addClass('input_area');
+        var input_area = $('<div/>').addClass('input_area').attr("aria-label", "Edit Markup Text here");;
         this.code_mirror = new CodeMirror(input_area.get(0), this._options.cm_config);
         // In case of bugs that put the keyboard manager into an inconsistent state,
         // ensure KM is enabled when CodeMirror is focused: