Merge pull request #11 from uclixnjupyternbaccessibility/tunde

jupyter#3955 changed span elements for sort buttons to button elements
uclixnjupyternbaccessibility · Jun 19, 2019 · af07a08 · af07a08
2 parents 7abd4c0 + 075831a
commit af07a08
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/notebook/templates/tree.html b/notebook/templates/tree.html
@@ -100,7 +100,7 @@
             <div id="notebook_list_header" class="row list_header">
               <div class="btn-group dropdown" id="tree-selector">
                 <button title="{% trans %}Select All / None{% endtrans %}" aria-label="{% trans %}Select All / None{% endtrans %}" type="button" class="btn btn-default btn-xs" id="button-select-all" role="checkbox">
-                  <input type="checkbox" class="pull-left tree-selector" id="select-all"><span id="counter-select-all">&nbsp;</span></input>
+                  <input type="checkbox" class="pull-left tree-selector" id="select-all" tabindex="-1"><span id="counter-select-all">&nbsp;</span></input>
                 </button>
                 <button title="{% trans %}Select Folders/All Notebooks/Running/Files {% endtrans %}" class="btn btn-default btn-xs dropdown-toggle" type="button" id="tree-selector-btn" data-toggle="dropdown" aria-expanded="true">
                   <span class="caret"></span>
@@ -122,22 +122,22 @@
                 </ul>
               </div>
               <div id="file_size" class="pull-right sort_button">
-                  <span class="btn btn-xs btn-default sort-action" id="file-size">
+                  <button type="button" class="btn btn-xs btn-default sort-action" id="file-size" aria-label="{% trans %}Sort by file size{% endtrans %}">
                       {% trans %}File size{% endtrans %}
                       <i class="fa"></i>
-                  </span>
+                  </button>
               </div>
               <div id="last_modified" class="pull-right sort_button">
-                  <span class="btn btn-xs btn-default sort-action" id="last-modified">
+                  <button type="button" class="btn btn-xs btn-default sort-action" id="last-modified" aria-label="{% trans %}Sort by last modified{% endtrans %}">
                       {% trans %}Last Modified{% endtrans %}
                       <i class="fa"></i>
-                  </span>
+                  </button>
               </div>
               <div id="sort_name" class="pull-right sort_button">
-                  <span class="btn btn-xs btn-default sort-action" id="sort-name">
+                <button type="button" class="btn btn-xs btn-default sort-action" id="sort-name" aria-label="{% trans %}Sort by name{% endtrans %}">
                       {% trans %}Name{% endtrans %}
                       <i class="fa fa-arrow-down"></i>
-                  </span>
+                </button>
               </div>
             </div>
           </div>