-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #45 docker #46
base: develop
Are you sure you want to change the base?
Issue #45 docker #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add FLASK_APP
and FLASK_DEBUG
environment variables
Tests fail because the template for config.py is missing. Need to update run-tests.yml
to support the new setup.
I noticed HTTPS isn't supported. I would like to retain that functionality.
Also, status page is now failing to load index and xml pages:
|
Need to pull in latest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
========================================
Coverage 98.64% 98.65%
========================================
Files 4 5 +1
Lines 1111 1114 +3
========================================
+ Hits 1096 1099 +3
Misses 15 15 ☔ View full report in Codecov by Sentry. |
- remove script_name from nginx.conf to fix index route - map ports 80:80 and 443:443 in docker-compose.yml - pin SQLAlchemy and Werkzeug versions - use 'docker compose' commands instead of 'docker-compose' - linting fixes - gitignore docker's copy of ngingx.conf and uwsgi.ini
- remove Python 3.7 from runner matrix - use Python 3.8 in Docker image - add newline to CONTRIBUTING.md - ignore markdown-style.rb rule for 'ul-indent' - use a single temporary Docker container for tests and tear down when complete - update CHANGELOG.md
Proposed Changes
This Dockerizes Quiz Extensions.
Resolves #45