Removes unnecessary call to get_qset from score_module and references…

… to qset in scorescreen.js
ucfopen · Feb 21, 2023 · 594bc1c · 594bc1c
1 parent 8435014
commit 594bc1c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/_score/score_module.php b/src/_score/score_module.php
@@ -9,7 +9,7 @@ class Score_Modules_Hangman extends Score_Module
 	public function check_answer($log)
 	{
 		// get qset once for options
-		if (empty($this->inst->qset)) $this->inst->get_qset($this->inst->id);
+		// if (empty($this->inst->qset)) $this->inst->get_qset($this->inst->id);
 
 		$wrong_limit = $this->inst->qset->data['options']['attempts'];
 		$is_partial  = $this->inst->qset->data['options']['partial'];

diff --git a/src/scoreScreen.js b/src/scoreScreen.js
@@ -21,18 +21,17 @@ const ScoreScreenApp = props => {
 					<td>{row.data[1]}</td>
 					<td>{row.data[2]}</td>
 				</tr>
-			)}
+			) }
 			</table>
 		</div>
 	);
 };
 
 export default ScoreScreenApp;
 
-const updateDisplay = (qset, scoreTable, title) => {
+const updateDisplay = (scoreTable, title) => {
 	ReactDOM.render(
 		<ScoreScreenApp
-			qset={qset}
 			scoreTable={scoreTable}
 			title={title}
 		/>,
@@ -43,10 +42,10 @@ const updateDisplay = (qset, scoreTable, title) => {
 const materiaCallbacks = {
 	start: (instance, qset, scoreTable, isPreview, qsetVersion) => {
 		title = instance.name;
-		updateDisplay(qset, scoreTable, title);
+		updateDisplay(scoreTable, title);
 	},
 	update: (qset, scoreTable) => {
-		updateDisplay(qset, scoreTable, title);
+		updateDisplay(scoreTable, title);
 	}
 };