Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_missing_modules should import rather than append to prioritize local #680

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

find_missing_modules should import rather than append to prioritize local #680

wants to merge 2 commits into from

Conversation

jonespm
Copy link
Contributor

@jonespm jonespm commented Jan 3, 2025 •
edited
Loading

Proposed Changes

  • Just change the script action to import rather than append which will put the local path first. Discovered this when testing a recent fix that added new methods.

Fixes #675

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (45ba5ac) to head (1696321).

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop      #680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           74        74           
  Lines         3764      3764           
=========================================
  Hits          3764      3764

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bennettscience
bennettscience approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@bennettscience bennettscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run into this bug before, but this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennettscience bennettscience bennettscience approved these changes

@Thetwam Thetwam Awaiting requested review from Thetwam Thetwam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find Missing Modules should import rather than append to prioritize local module
2 participants
@jonespm @bennettscience