Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for sqlite3 operation error in cache #40

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

redhog
Copy link
Collaborator

@redhog redhog commented Oct 2, 2024

diskcache isn't 100% threadsafe and can under certain conditions end up unable to open the sqlite database with an OperationalError. This only happens if threads do not close their cache when not using it. Closing the cache and reopening it is slightly slower, but fixes this problem. Solution copied from the documentation of diskcache.

@shreyashankar shreyashankar changed the base branch from main to cacheop October 2, 2024 15:41
@shreyashankar
Copy link
Collaborator

Thank you! Merging into another staging branch to run tests.

@shreyashankar shreyashankar merged commit 8fa7f23 into ucbepic:cacheop Oct 2, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants