This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Upgrade to Chisel 6 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Emin017
commented
Mar 10, 2024
Emin017
commented
- Upgrade to Chisel 6
- Rename Const variables to Consts (Const is an object in Chisel 6)
Const is an object in chisel6: https://www.chisel-lang.org/api/latest/chisel3/Const$.html
|
Thanks! This looks generally good, but the Makefile needs to be adjusted to fix the verilator error. Maybe just remove the |
Verilator 5.020 (released 2024/01/01) requires C++14: https://verilator.org/guide/latest/changes.html.
|
Add some changes:
|
ekiwi
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.