Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update epiphany to 44.0 #10

Closed

Conversation

sergio-costas
Copy link
Contributor

This is still a work-in-progress:

  • to build it, a manual "apt update" must be done inside the build environment
  • the audio still doesn't work

Fix #6

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please check only the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • OS (please include version):
  • Any other relevant environment information:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

This is still a work-in-progress:

- to build it, a manual "apt update" must be done inside the
  build environment
- the audio still doesn't work

Fix ubuntu#6
@sergio-costas sergio-costas requested a review from jbicha August 29, 2023 15:18
@jbicha
Copy link
Collaborator

jbicha commented Sep 1, 2023

This snap update passes my basic manual tests.

By the way, the latest 44.x version is 44.6, but the automation would pick that up.

@sergio-costas
Copy link
Contributor Author

@jbicha If you open a youtube video, does it work with sound?

@jbicha
Copy link
Collaborator

jbicha commented Sep 1, 2023

Yes. I have sound in the sample YouTube video. My host OS is Ubuntu "Mantic"

@sergio-costas
Copy link
Contributor Author

I tried with 44.6, but still no sound... This is odd. Have you tried to do a "snapcraft clean" before?

@jbicha
Copy link
Collaborator

jbicha commented Sep 1, 2023

Yes, but I used the Artifact produced on the Checks tab at #10

@sergio-costas
Copy link
Contributor Author

@jbicha This is even more odd... I tried that snap, and it still doesn't have audio.

@sergio-costas
Copy link
Contributor Author

Just in case... Can you check if you have the .deb version installed?

@jbicha
Copy link
Collaborator

jbicha commented Sep 25, 2023

Just in case... Can you check if you have the .deb version installed?

I did. But I've uninstalled it now and the sound worked.

So then I installed Ubuntu 23.10 Beta (default install, didn't check boxes to install anything extra) in GNOME Boxes and then installed the epiphany snap from this CI run and sound worked for me with a YouTube video.

@sergio-costas
Copy link
Contributor Author

I'm really puzzled...

@kenvandine
Copy link
Member

The snap built in the CI build worked fine for me, including audio in youtube. I think it's worth landing this so we can let the automation bump it to the latest.

@sergio-costas
Copy link
Contributor Author

Ok, now it seems to work even in my system... odd.

@sergio-costas
Copy link
Contributor Author

It seems that epiphany 45 can't be built with core22...

:: ../src/meson.build:111:16: ERROR: Dependency lookup for webkitgtk-6.0 with method 'pkgconfig' failed: Invalid version, need 'webkitgtk-6.0' ['>= 2.41.1'] found '2.40.5'.

@jbicha
Copy link
Collaborator

jbicha commented Oct 12, 2023

@sergio-costas webkit2gtk 2.42 landed in Ubuntu 22.04 LTS this week. Once the GNOME SDK is updated for that, you should be able to update Epiphany to 45.0

@jbicha
Copy link
Collaborator

jbicha commented Nov 7, 2023

Epiphany 45.0 is already in the repository and was pushed to the stable channel earlier.

@jbicha jbicha closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update epiphany snap to 44
3 participants