Refresh releases and assets #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
That's the only surprising behaviour affecting WSL1. Also, if systemd is disabled (or the cloud-int.service unit), running cloud-init --wait wouild block forever. While I'd like the cloud-init command to properly handle the cases where it cannot even start, this is a simple enough fix on our side. If systemd is disabled by /etc/wsl.conf, systemctl is-enabled --quiet cloud-init.service would still report the unit as enabled, so we need a broader check.
If this works as expected, one test case should run under WSL1. Without the current patch that would block forever. With the launcher patch, cloud-init status --wait won't even run, so no hangs.
CarlosNihelton
force-pushed
the
fix-on-wsl1
branch
from
0006afd to
bdbc15b
Compare
github-actions
bot
force-pushed
the
auto-update-releases-fix-on-wsl1
branch
from
d846a75 to
add2428
Compare
CarlosNihelton
force-pushed
the
fix-on-wsl1
branch
from
bdbc15b to
472a2d8
Compare
|
This has the same contents as #503 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated pull request by GitHub Action