Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert pydantic upgrade until required fixes can be made #184

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

KyleGospo
Copy link
Member

This reverts commit 319fffe.

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this revert is needed to build.

However, probably we DO want to upgrade to pydantic 2.x... but it does require effort, not a drop-in upgrade for most things.

@KyleGospo KyleGospo changed the title Revert "chore(deps): bump pydantic from 1.10.2 to 2.4.2 (#173)" fix: Revert pydantic upgrade until required fixes can be made Jan 6, 2024
@KyleGospo KyleGospo merged commit 1ff59d3 into main Jan 6, 2024
2 checks passed
@KyleGospo KyleGospo deleted the revert-pydantic branch January 6, 2024 18:35
@KyleGospo
Copy link
Member Author

I'm assuming this revert is needed to build.

However, probably we DO want to upgrade to pydantic 2.x... but it does require effort, not a drop-in upgrade for most things.

You got it, just doing some housekeeping ATM. I'll circle back and do the fixes needed for this dependency upgrade asap.

@bsherman
Copy link
Contributor

I did confirm that 1.x releases of pydantic are still being done, so we don't have to do a full update to 2.x just for security... at least not yet.

https://github.com/pydantic/pydantic/releases/tag/v1.10.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants