Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to official upstream images #687

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: switch to official upstream images #687

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7620bb9
chore: switch to official upstream images
p5 Dec 2, 2024
0a5e79e
fix: base image matrix build arg
p5 Dec 2, 2024
258f9eb
fix: update base_image matrix variable casing
p5 Dec 2, 2024
51d2ad9
fix: pull the correct base image
p5 Dec 2, 2024
6978934
chore: reverse
p5 Dec 2, 2024
05addf3
fix: prefix source image names with "fedora-"
p5 Dec 2, 2024
a43dbe7
fix: some hacks to work around different naming conventions
p5 Dec 2, 2024
07920b0
fix: check source_image for fedora- prefix
p5 Dec 2, 2024
1ec625e
fix: this should be it - use source_image if prefixed with fedora-
p5 Dec 2, 2024
453c4c5
Merge branch 'main' into switch-to-official-images
p5 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/reusable-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ jobs:
- base
- lazurite
- vauxite
include:
- image_name: silverblue
base_image: quay.io/fedora/fedora-silverblue
- image_name: kinoite
base_image: quay.io/fedora/fedora-kinoite
- image_name: sericea
base_image: quay.io/fedora/fedora-sway-atomic
- image_name: onyx
base_image: quay.io/fedora/fedora-budgie-atomic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just go with the upstream names so they end up being sway-main and budgie-main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do, though it may be best waiting for the next major version rather than introducing breaking changes in the middle of a cycle


steps:
# Checkout push-to-registry action GitHub repository
Expand Down Expand Up @@ -160,7 +169,11 @@ jobs:
command: |
# pull the base image used for FROM in containerfile so
# we can retry on that unfortunately common failure case
podman pull quay.io/${{ env.SOURCE_ORG }}/${{ env.SOURCE_IMAGE }}:${{ matrix.fedora_version }}
if [[ -n "${{ matrix.base_image }}" ]]; then
podman pull ${{ matrix.base_image }}:${{ matrix.fedora_version }}
else
podman pull quay.io/${{ env.SOURCE_ORG }}/${{ env.SOURCE_IMAGE }}:${{ matrix.fedora_version }}
fi
podman pull ${{ env.IMAGE_REGISTRY }}/akmods:main-${{ matrix.fedora_version }}
podman pull ${{ env.IMAGE_REGISTRY }}/main-kernel:${{ env.KERNEL_VERSION }}

Expand Down Expand Up @@ -190,6 +203,7 @@ jobs:
tags: |
${{ steps.generate-tags.outputs.alias_tags }}
build-args: |
${{ matrix.base_image && format('BASE_IMAGE={0}', matrix.base_image) || '' }}
IMAGE_NAME=${{ matrix.image_name }}
SOURCE_ORG=${{ env.SOURCE_ORG }}
SOURCE_IMAGE=${{ env.SOURCE_IMAGE }}
Expand Down
Loading