-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct rpm-ostree issue that prevents rollbacks #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at our rpm-ostree.spec file in https://github.com/ublue-os/packages/blob/main/staging/rpm-ostree/rpm-ostree.spec
It doesn't match upstream https://github.com/coreos/rpm-ostree/blob/main/packaging/rpm-ostree.spec
New requirements:
fuse3
packageusr/bin/setpriv
Dropped requirements:
libzstd-devel
Is this intended?
Yes, it's copied from Fedora. |
Yep, I just went down that path, to see if that's where you pulled it. I agree, this spec matches. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good.
Upstream issue: coreos/rpm-ostree#5048
Upstream MR: coreos/rpm-ostree#5069
Package source: https://github.com/ublue-os/packages/tree/main/staging/rpm-ostree
Also sneaks in a quick fix for some whitespace issues.