fix: remove ffmpeg-free from all images #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qoijjj would you please edit the description to remove the default "Please read contribution guide" and replace with a bit of context for the PR? Helpful for the future (and current) maintainers who don't know the context from Discord. Thank you! |
|
@bsherman yes of course, one minute |
KyleGospo
approved these changes
May 20, 2024
p5
approved these changes
May 20, 2024
jenalj
added a commit
to jenalj/ublue-main
that referenced
this pull request
May 25, 2024
fix: remove ffmpeg-free from all images (ublue-os#582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build, which broke because
ffmpeg-freewas added to the recommends for thefirefoxrpm, which is in the base upstream image:https://src.fedoraproject.org/rpms/firefox/c/f4c7885a695292c6b3cdffa4239455f1b336307a?branch=rawhide
This means that when uBlue builds the main images and it tries to remove
libavcodec-free, it fails becauselibavcodec-freeis a dependency offfmpeg-free, which is now in the base upstream image.Adding
ffmpeg-freeto the removals list as well, as is done in this PR, allows rpm-ostree to go ahead with thelibavcodec-freeremoval by telling it thatffmpeg-freeshould also be removed.