Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce package scope and remove redundancies #544

Closed
wants to merge 3 commits into from
+0 −5
Closed

feat: reduce package scope and remove redundancies #544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62a7efa
feat: reduce package scope and remove redundancies
RoyalOughtness Apr 6, 2024
f1ae486
fixes
RoyalOughtness Apr 6, 2024
e7ed28e
fixes
RoyalOughtness Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"all": [
"alsa-firmware",
"android-udev-rules",
"apr",
"apr-util",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APR was added specifically to support installations of Davinci Resolve ( #91 ) and was a nice example of a user providing a clean request for package support or alternative documentations.

There's no harm to keeping this, but removing it is reversing a past decision to save... 246k on a download?

I'm not sure I would support adding this today, but I'm not really in favor of removing support without a strong reason.

Copy link
Contributor

@fiftydinar fiftydinar Apr 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unofficial Davinci Resolve flatpak is in progress:
https://github.com/pobthebuilder/resolve-flatpak

davincibox also exists:
https://github.com/zelikos/davincibox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save... 246k on a download?

Image size is not the purpose of this PR 🙂

"distrobox",
"ffmpeg",
"ffmpeg-libs",
Expand All @@ -17,7 +15,6 @@
"google-noto-sans-sundanese-fonts",
"grub2-tools-extra",
"heif-pixbuf-loader",
"htop",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added over a year ago ( #82 ) as an opinionated, lightweight helpful utility. The only concern I've ever seen about this is that it comes with a desktop file which shows up in DE app lists and some people seem to find that offensive.

I'm not inclined to remove it.

Copy link
Contributor

@fiftydinar fiftydinar Apr 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I've ever seen about this is that it comes with a desktop file which shows up in DE app lists and some people seem to find that offensive.

This one can be easy solved with:
echo 'Hidden=true' >> /usr/share/applications/htop.desktop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I am fine with hiding the desktop icon if the group wishes to do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I am fine with hiding the desktop icon if the group wishes to do that.

I would also do that for nvtop too, if majority agrees.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 for mangling .desktop files in main - I agree it's annoying, which is why we do it downstream. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also agreed, though, I'd suggest that be a distinct PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsherman ultimately this PR is about giving main a well-defined scope, which it currently lacks. Without which, it is not clear at all what belongs here, upstream, or downstream.

If these packages are universally useful, they should be added in fedora comps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoijjj I just addressed this in top-level comment.

"intel-media-driver",
"just",
"kernel-tools",
Expand All @@ -42,7 +39,6 @@
"solaar-udev",
"symlinks",
"tcpdump",
"tmux",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added nearly a year ago ( #190 ) due to multiple contributors/users who believed it to be a useful, lightweight tool which is valuable on the host main images and who realized it was being added on several downstream images.

I'm not inclined to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second this. Similar to vim this is a popular tool for folks and adds almost no size to the image to include it.

"traceroute",
"vim",
"wireguard-tools",
Expand Down Expand Up @@ -194,7 +190,6 @@
"xrdb"
],
"sericea": [
"clipman",
RoyalOughtness marked this conversation as resolved.
Show resolved Hide resolved
"gvfs-mtp",
"thunar-volman",
"tumbler"
Expand Down