Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix possible empty version meta on image #492

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Feb 6, 2024

This ensures that when inspecting upstream image, if an error occurs, or the resulting value is empty or 'null', we fail our build instead of propagating a bogus version downstream.

Relates: #487

This ensures that when inspecting upstream image, if an error occurs, or
the resulting value is empty or 'null', we fail our build instead of
propegating a bogus version downstream.

Relates: #487
@bsherman bsherman requested a review from a team February 6, 2024 06:33
@bsherman bsherman requested a review from castrojo as a code owner February 6, 2024 06:33
@bsherman bsherman requested a review from a team February 6, 2024 06:37
@castrojo castrojo added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@castrojo castrojo added this pull request to the merge queue Feb 6, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Feb 6, 2024
@castrojo castrojo merged commit 43c383b into main Feb 6, 2024
24 checks passed
@castrojo castrojo deleted the better-version-check branch February 6, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants