feat: allow rescue/emergency boot with grub cmdline args #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a systemd-generator to dyamically write a drop-in config for the rescue and emergency services only when they are requested via the kernel cmdline, which requires console/grub access. This allows use of these modes with the default Fedora state of a password locked root user, but does not auto-allow root access in the case of a failed fsck-check, which can also drop into the emergency shell. Relates: #470
|
@ublue-os/approver please do NOT merge this until we've collected feedback. :-) Thank you. |
|
Some notes for reference:
|
|
Looks sane to me. Arguably we could try to put this in systemd upstream too. |
I'm not sure how easy it is to get merged into different projects. At the least, I figured we'd include it here and I'll PR to CoreOS. Then we'd have running use cases before pushing further upstream. |
TriMoon
reviewed
Feb 5, 2024
@cgwalters , I had planned to PR this into CoreOS as a replacement for the current static drop-ins. Would prefer I first attempt going upstream to systemd? |
|
Landing in FCOS first sounds totally sane to me. |
bsherman
added a commit
that referenced
this pull request
Feb 23, 2024
I'm confused that the original PR ( #488 ) failed to COPY this file via the Containerfile, thus for the last few weeks this has not worked as intended. Given several people tested it, I'm not sure how we missed that, but this resolves it regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a systemd-generator to dyamically write a drop-in config for the rescue and emergency services only when they are requested via the kernel cmdline, which requires console/grub access. This allows use of these modes with the default Fedora state of a password locked root user, but does not auto-allow root access in the case of a failed fsck-check, which can also drop into the emergency shell.
Relates: #470