Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove systemd unit disable for unknown services on bluefin-dx #2105

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

ledif
Copy link
Contributor

@ledif ledif commented Jan 4, 2025

There are no units named pmie.service or pmlogger.service. Trying to disable them is throwing errors that these units do not exist when building dx variants.

Stable: https://github.com/ublue-os/bluefin/actions/runs/12604017907/job/35130160146

2025-01-03T21:38:43.1653202Z + systemctl disable pmie.service
2025-01-03T21:38:43.1774426Z Failed to disable unit: Unit pmie.service does not exist
2025-01-03T21:38:43.1775098Z Failed to disable unit: Unit pmie.service does not exist
2025-01-03T21:38:43.1783989Z + systemctl disable pmlogger.service
2025-01-03T21:38:43.1904775Z Failed to disable unit: Unit pmlogger.service does not exist
2025-01-03T21:38:43.1905417Z Failed to disable unit: Unit pmlogger.service does not exist

GTS: https://github.com/ublue-os/bluefin/actions/runs/12532949173/job/34952152148

2024-12-29T06:03:04.6735521Z + systemctl disable pmie.service
2024-12-29T06:03:04.6857150Z Failed to disable unit, unit pmie.service does not exist.
2024-12-29T06:03:04.6857921Z Failed to disable unit, unit pmie.service does not exist.
2024-12-29T06:03:04.6869052Z + systemctl disable pmlogger.service
2024-12-29T06:03:04.6989691Z Failed to disable unit, unit pmlogger.service does not exist.
2024-12-29T06:03:04.6990463Z Failed to disable unit, unit pmlogger.service does not exist.

@ledif ledif requested a review from castrojo as a code owner January 4, 2025 01:41
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dx Developer Experience Image specific labels Jan 4, 2025
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 90% sure these are vestigial anyway, thanks for the cleanup!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2025
@castrojo castrojo enabled auto-merge January 4, 2025 01:43
@castrojo castrojo added this pull request to the merge queue Jan 4, 2025
Merged via the queue into ublue-os:main with commit eb2ac92 Jan 4, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants