feat(ci): Replace rpm-ostree with dnf5 during build #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
KyleGospo
changed the title
There was a problem hiding this comment.
I haven't personally encountered any of these problems in PlaytronOS, but Bluefin has run into some odd issues with DNF 5 over in their (new) related PR: ublue-os/bluefin#1954
| @@ -37,125 +37,79 @@ COPY system_files/desktop/shared system_files/desktop/${BASE_IMAGE_NAME} / | |||
|
|
|||
| # Update packages that commonly cause build issues | |||
| RUN --mount=type=cache,dst=/var/cache/rpm-ostree \ | |||
There was a problem hiding this comment.
We've been using DNF 5 in PlaytronOS for a few months now and, yes, it's amazing!
One of the great things is that it takes care of dependencies. It's okay if a package is slightly out-of-date, DNF will automatically deal with that by updating the package(s) as necessary. rpm-ostree had a hard time because it didn't know how to update base packages. You should be able to remove this entire "Update packages that commonly cause build issues" block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.