Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add universal-pidff for direct drive wheels #283

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JPZ13
Copy link

@JPZ13 JPZ13 commented Dec 17, 2024

Closes #281

Description

This pull request adds the universal-pidff package to allow for force feedback for direct drive wheelbases

Image

Bazzite

Note: I'm also in process of building the RPM for universal-pidff. Will update this draft PR once that is done
Update: I have the universal-pidff package built. The pull request is here, and the COPR builds are here

@JPZ13
Copy link
Author

JPZ13 commented Dec 17, 2024

Flipping the PR to ready for review to allow for the builds to be triggered by a maintainer. I'll still probably have to play with it a bit to get it to build right though

Thank you for maintaining the project 🙏

@JPZ13 JPZ13 marked this pull request as ready for review December 17, 2024 19:17
@JPZ13 JPZ13 requested a review from castrojo as a code owner December 17, 2024 19:17
@KyleGospo KyleGospo enabled auto-merge December 17, 2024 19:18
KyleGospo
KyleGospo previously approved these changes Dec 17, 2024
@KyleGospo
Copy link
Member

Thanks for doing this!

@JPZ13
Copy link
Author

JPZ13 commented Dec 17, 2024

For sure! Thanks for accepting the PR, @KyleGospo. Is there anything I can do to help test?

@KyleGospo
Copy link
Member

Yeah, we can work on that together with the testing image since I don't have the hardware. In the meantime though you've got to build issue here that needs to be resolved

@KyleGospo
Copy link
Member

It looks like only Fedora 40 failed, so you could modify your build to not build this for 40.

Signed-off-by: J.P. Zivalich <[email protected]>
auto-merge was automatically disabled December 17, 2024 19:56

Head branch was pushed to by a user without write access

@JPZ13
Copy link
Author

JPZ13 commented Dec 17, 2024

I think the 41 build failed as well: https://github.com/ublue-os/akmods/actions/runs/12371852566/job/34555002792?pr=283

Am I able to re-run builds, or do maintainers have to manually trigger them? It's my first time building an RPM package, let alone a kernel mod. I'd hate to be a bother while I'm running into beginner mistakes

On the flipside, I'd be happy to do this for other wheel drivers if I can get this first one working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add universal-pidff to allow direct drive force feedback racing wheels
2 participants