Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove kernel version from kmod name #257

Merged
merged 6 commits into from
Oct 20, 2024

Conversation

antheas
Copy link
Contributor

@antheas antheas commented Oct 19, 2024

This PR removes the version name of the kernel from akmods to cleanup changelogs and bundles the akmods used to build the kmods into the resulting image, preventing version drift.

Closes #255

@antheas antheas requested a review from castrojo as a code owner October 19, 2024 23:08
@antheas antheas force-pushed the remove-version-bundle-akmods branch from b747b50 to 0501278 Compare October 19, 2024 23:12
p5
p5 previously approved these changes Oct 19, 2024
@p5 p5 self-requested a review October 19, 2024 23:40
m2Giles
m2Giles previously approved these changes Oct 20, 2024
@m2Giles
Copy link
Member

m2Giles commented Oct 20, 2024

You didn't do zfs.

Containerfile.common Show resolved Hide resolved
@bsherman bsherman dismissed their stale review October 20, 2024 19:28

Question answered re: where in RPM the version was removed.

bsherman
bsherman previously approved these changes Oct 20, 2024
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title and description should be updated to remove references to #254 (bundling akmods deps), but removing kernel version from kmod name in rpm metadata looks good!

@antheas antheas changed the title feat: Remove kernel version from kmod name, bundle akmods feat: Remove kernel version from kmod name Oct 20, 2024
@m2Giles m2Giles added this pull request to the merge queue Oct 20, 2024
Merged via the queue into ublue-os:main with commit 3516e7b Oct 20, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kmod name contains kernel version
4 participants